Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ppc64le architecture from Docker build scripts #378

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

krinkinmu
Copy link
Contributor

We don't build images for ppc64le anyways, so it's very unlikely that this functionality is being used.

Tested that the change does not break anything by running:

cd docker
OS_FAMILY=linux ./push.sh

Fixes #377

+cc @phlax @clnperez

We don't build images for ppc64le anyways, so it's very unlikely that
this functionality is being used.

Signed-off-by: Mikhail Krinkin <[email protected]>
@krinkinmu krinkinmu requested a review from a team as a code owner January 17, 2025 14:18
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @krinkinmu

@phlax phlax enabled auto-merge (squash) January 17, 2025 14:22
@phlax phlax merged commit f740646 into envoyproxy:main Jan 17, 2025
2 checks passed
@clnperez
Copy link

we're working on getting it working still. missed this last week. envoyproxy/envoy#25090 (comment)

however, we're not using this afaik , just bazel build

@clnperez
Copy link

FYI @Jenkins-J

@phlax
Copy link
Member

phlax commented Jan 24, 2025

@clnperez flagging that when we shift to using the bazel llvm toolchain we will still be using the same source for llvm bins - ie:

https://github.com/llvm/llvm-project/releases/

in the event that the current envoy llvm version is not available for ppc64le - you will either need to patch to set an llvm version that is available - or have (someone at the) llvm project add it - creating the bins is a "volunteer" thing

@clnperez
Copy link

clnperez commented Jan 28, 2025

@phlax I talked with our toolchain team, and it sounds like their agreement with that llvm volunteer team is that we own our own binares. Power hardware isn't so easy to come by. :D (but i'll not miss an opportunity to remind folks in opensource projects they request Power VMs at OSU: https://osuosl.org/services/powerdev)

They're here: https://github.com/IBM/llvm-project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ppc64le support
3 participants